From 0c4ec73df6cbf06e2baa5cb2664540906e4bdc40 Mon Sep 17 00:00:00 2001 From: Daniel Thwaites Date: Wed, 19 Mar 2025 17:10:24 +0000 Subject: [PATCH] firefox: improve option descriptions for extensions (#998) - Made the descriptions of `colorTheme.enable` and `firefoxGnomeTheme.enable` specify which Firefox derivative they apply to, to clarify that these options are specific to each derivative. - Switched from `mkEnableTarget` to `mkEnableOption`, as these options are not strictly targets: they enable additional programs. This also changes the option description slightly. - Removed the multi-line string as this was adding whitespace where it's not needed, due to the trailing newline. Link: https://github.com/danth/stylix/pull/998 Reviewed-by: NAHO <90870942+trueNAHO@users.noreply.github.com> --- modules/firefox/hm.nix | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/modules/firefox/hm.nix b/modules/firefox/hm.nix index e15c802e..9a35013e 100644 --- a/modules/firefox/hm.nix +++ b/modules/firefox/hm.nix @@ -61,14 +61,9 @@ in default = [ ]; }; - colorTheme.enable = config.lib.stylix.mkEnableTarget '' - [Firefox Color](https://color.firefox.com/) theme - '' false; + colorTheme.enable = lib.mkEnableOption "[Firefox Color](https://color.firefox.com/) on ${target.name}"; - firefoxGnomeTheme.enable = config.lib.stylix.mkEnableTarget '' - [Firefox GNOME - theme](https://github.com/rafaelmardojai/firefox-gnome-theme) - '' false; + firefoxGnomeTheme.enable = lib.mkEnableOption "[Firefox GNOME theme](https://github.com/rafaelmardojai/firefox-gnome-theme) on ${target.name}"; } ) targets );