From ee128898d9d8daa1168c06a2d13266d41903099e Mon Sep 17 00:00:00 2001 From: NAHO <90870942+trueNAHO@users.noreply.github.com> Date: Wed, 27 Aug 2025 00:42:43 +0200 Subject: [PATCH 1/2] doc/src/commit_convention: consistently indicate root directories Fixes: 57d036d92283 ("doc: commit_convention: overhaul and formalize unspoken rules (#1717)") --- doc/src/commit_convention.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/commit_convention.md b/doc/src/commit_convention.md index 506d6d4e..11b22dd0 100644 --- a/doc/src/commit_convention.md +++ b/doc/src/commit_convention.md @@ -21,7 +21,7 @@ where | Element | Description | |-----------------------|-------------| -| `«SUBSYSTEM»` | Area of patched files, optionally nested using `:` for general subsystems and `/` for paths.

For example, a patch to `/stylix/hm/` should be formatted as `stylix/hm` instead of `stylix: hm`, while `/stylix/*/palette.nix` should be formatted as `stylix: palette`.

Specific conventions include simplifying `modules/«MODULE»` to `«MODULE»`, mapping `/flake.{lock,nix}` and `/flake/` to `flake`, mapping `/.github/` to `ci`, and using `treewide` for changes that cannot be categorized under a more specific subsystem. | +| `«SUBSYSTEM»` | Area of patched files, optionally nested using `:` for general subsystems and `/` for paths.

For example, a patch to `/stylix/hm/` should be formatted as `stylix/hm` instead of `stylix: hm`, while `/stylix/*/palette.nix` should be formatted as `stylix: palette`.

Specific conventions include simplifying `/modules/«MODULE»` to `«MODULE»`, mapping `/flake.{lock,nix}` and `/flake/` to `flake`, mapping `/.github/` to `ci`, and using `treewide` for changes that cannot be categorized under a more specific subsystem. | | `«SUMMARY»` | Concise, single-line explanation of up to 72 characters, written in the imperative mood, starting lowercase, and not ending with punctuation. | | `«BODY»` | Detailed, self-contained explanation of the problem, its user impact, the technical solution, and any optimizations or trade-offs, focusing on one problem per patch. | | `«BREAKING_CHANGE»` | Dedicated `BREAKING CHANGE: «BODY»` section for breaking changes. | From 98592e3c5926b67449e558d61a53e5a991d5dc16 Mon Sep 17 00:00:00 2001 From: NAHO <90870942+trueNAHO@users.noreply.github.com> Date: Wed, 27 Aug 2025 00:47:20 +0200 Subject: [PATCH 2/2] doc/src/commit_convention: add subsystem nesting commit example --- doc/src/commit_convention.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/src/commit_convention.md b/doc/src/commit_convention.md index 11b22dd0..7ae53c8e 100644 --- a/doc/src/commit_convention.md +++ b/doc/src/commit_convention.md @@ -42,6 +42,9 @@ The following examples should demonstrate everything: - [`kde: replace systemd unit with AutostartScript for theme application`]( https://github.com/nix-community/stylix/commit/e0a41d3a2562ce1b43cad8560333673d04b111b8) +- [`stylix/droid: fix import droid modules`]( + https://github.com/nix-community/stylix/commit/e01d56cf5c00449f4d0af4013512ed906ed7d3c9) + - [`stylix: do not check lambda pattern names with deadnix`]( https://github.com/nix-community/stylix/commit/4add678fe3978177744e8af3c72a6a8a1288227b)