I found that there were some color choices in the k9s module that
weren't aligned with the style guide. Most notably this resulted in
healthy resources being displayed in red while unhealthy resources were
blue.
I tried not to make any subjective changes to the original module
because overall, it was very well done, and there's no right answer when
it comes to things aren't covered by the style guide. In some cases
where the style guide doesn't help, I looked at other modules for
answers.
These are the changes, and the reason for them.
1. prompt.bgColor from base00 to "default" for transparency to shell
background.
2. prompt.suggestColor from base0A to base02 because base02 is used as
fish_color_autosuggestion in base16-fish via the fish module.
3. dialog.bgColor from "default" to base01 because the style guide says
base01 is for alternate background, and that's what this is.
4. dialog.buttonBgColor from base0C to base02 because base0C resulted in
white on bright and made button text illegible. Using base02 allows
the not-selected button background to still be raised off the base01
background.
5. dialog.buttonFocusFgColor from base0E to base11 because there was
another light-on-light issue here that made the focused button text
illegible. This change keeps the base0B background color, but uses
the darkest possible foreground text to be legible.
6. frame.crumbs.activeColor from base01 to base02 because the style
guide says base02 should be used for selection background. This
creates a small distinction between the active crumb and the others
that didn't previously exist.
7. frame.yaml.(keyColor|colonColor|valueColor) are changed to match yaml
syntax highlighting from other modules such as bat.
8. frame.logs.indicator.bgColor from base0C to "default" to fix another
very low contrast problem of having base05 text on a base0C
background.
9. frame.logs.indicator.toggle(On|Off)Color weren't set before, so I
made them base0B and base04 because base0B is customarily green or an
"on" color, and base04 is the alternate text color.
In the frame.status section I changed newColor, modifyColor, addColor,
and errorColor. I left highlightColor, killColor, and completedColor as
they were.
1. newColor is the color of all resources in a normal state. I chose
base0C as a neutral color for this. Anything would have been better
than the base08 (typically red) that it was.
2. modifyColor is the color of a resource when it's in some
transitioning state. I could have made this base09 or base0A, but
given that base0A is used for many other things I went with base09.
3. addColor is the color of a resource when it first appears. Using
base0C (typically green) is customary for something like this. It had
been base09 (typically orange) which has the opposite meaning.
4. errorColor is given to resources in an error state. This is the
perfect place to use base08 according to the style guide.
Link: https://github.com/danth/stylix/pull/999
Reviewed-by: Marc Jakobi <mrcjkb89@outlook.com>
Reviewed-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
41a773fb0f