From cfa1df00881508192926ff38ab6c5ae93fca1a89 Mon Sep 17 00:00:00 2001 From: Gaetan Lepage Date: Wed, 24 Dec 2025 12:52:52 +0100 Subject: [PATCH] tests: disable tests relying on phpPackages.php-codesniffer https://github.com/NixOS/nixpkgs/pull/459254#issuecomment-3689578764 --- plugins/by-name/conform-nvim/formatter-packages.nix | 5 ++++- tests/all-package-defaults.nix | 4 ++++ .../test-sources/plugins/by-name/efmls-configs/default.nix | 7 ++++++- tests/test-sources/plugins/by-name/none-ls/default.nix | 5 +++++ 4 files changed, 19 insertions(+), 2 deletions(-) diff --git a/plugins/by-name/conform-nvim/formatter-packages.nix b/plugins/by-name/conform-nvim/formatter-packages.nix index 7dfcc205..91fe15e1 100644 --- a/plugins/by-name/conform-nvim/formatter-packages.nix +++ b/plugins/by-name/conform-nvim/formatter-packages.nix @@ -13,6 +13,10 @@ in { inherit states; formatter-packages = { + # 2025-12-24: phpPackages.php-codesniffer is broken + # https://github.com/NixOS/nixpkgs/pull/459254#issuecomment-3689578764 + phpcbf = states.broken php84Packages.php-codesniffer; + # 2025-12-20 build failure # https://github.com/NixOS/nixpkgs/issues/472704 terragrunt_hclfmt = states.broken terragrunt; @@ -137,7 +141,6 @@ in perltidy = perl538Packages.PerlTidy; pg_format = pgformatter; php_cs_fixer = php83Packages.php-cs-fixer; - phpcbf = php84Packages.php-codesniffer; inherit (php84Packages) phpinsights; prolog = swi-prolog; pyproject-fmt = python313Packages.pyproject-parser; diff --git a/tests/all-package-defaults.nix b/tests/all-package-defaults.nix index 02f56d99..dff24b99 100644 --- a/tests/all-package-defaults.nix +++ b/tests/all-package-defaults.nix @@ -13,6 +13,10 @@ let }; disabledPackages = [ + # 2025-12-24: phpPackages.php-codesniffer is broken + # https://github.com/NixOS/nixpkgs/pull/459254#issuecomment-3689578764 + "php-codesniffer" + # 2025-11-15 dependency swift is broken # https://github.com/NixOS/nixpkgs/issues/461474 "sourcekit-lsp" diff --git a/tests/test-sources/plugins/by-name/efmls-configs/default.nix b/tests/test-sources/plugins/by-name/efmls-configs/default.nix index 573d4d29..d15825b8 100644 --- a/tests/test-sources/plugins/by-name/efmls-configs/default.nix +++ b/tests/test-sources/plugins/by-name/efmls-configs/default.nix @@ -21,7 +21,12 @@ "JSON" ]; - brokenTools = [ ]; + brokenTools = [ + # 2025-12-24: phpPackages.php-codesniffer is broken + # https://github.com/NixOS/nixpkgs/pull/459254#issuecomment-3689578764 + "phpcbf" + "phpcs" + ]; # TODO: respect unpackaged from generated unpackaged = [ diff --git a/tests/test-sources/plugins/by-name/none-ls/default.nix b/tests/test-sources/plugins/by-name/none-ls/default.nix index 96578a57..854065fa 100644 --- a/tests/test-sources/plugins/by-name/none-ls/default.nix +++ b/tests/test-sources/plugins/by-name/none-ls/default.nix @@ -100,6 +100,11 @@ sources = let disabled = [ + # TODO Added 2025-12-24: phpPackages.php-codesniffer is broken + # https://github.com/NixOS/nixpkgs/pull/459254#issuecomment-3689578764 + "phpcbf" + "phpcs" + # TODO Added 2025-12-20 build failure # https://github.com/NixOS/nixpkgs/issues/472704 "terragrunt_fmt"