firefox: allow separators in bookmarks (#7284)

Allow users to create separators in their Firefox bookmarks.

Co-authored-by: xaltsc <hey@xaltsc.dev>

modules/programs/firefox/profiles/bookmark-types.nix

@@ -50,6 +50,8 @@ rec {
 
   bookmarkType = types.addCheck bookmarkSubmodule (x: x ? "url");
 
+  separatorType = types.enum [ "separator" ];
+
   directoryType =
     types.submodule (
       { name, ... }:
@@ -83,5 +85,9 @@ rec {
       description = "directory submodule";
     };
 
-  nodeType = types.either bookmarkType directoryType;
+  nodeType = types.oneOf [
+    bookmarkType
+    directoryType
+    separatorType
+  ];
 }

modules/programs/firefox/profiles/bookmarks.nix

@@ -45,9 +45,16 @@ let
         ${allItemsToHTML (indentLevel + 1) directory.bookmarks}
         ${indent indentLevel}</DL><p>'';
 
+      separatorToHTML = indentLevel: "${indent indentLevel}<HR>";
+
       itemToHTMLOrRecurse =
         indentLevel: item:
-        if item ? "url" then bookmarkToHTML indentLevel item else directoryToHTML indentLevel item;
+        if item ? "url" then
+          bookmarkToHTML indentLevel item
+        else if item == "separator" then
+          separatorToHTML indentLevel
+        else
+          directoryToHTML indentLevel item;
 
       allItemsToHTML =
         indentLevel: bookmarks: lib.concatStringsSep "\n" (map (itemToHTMLOrRecurse indentLevel) bookmarks);
@@ -106,6 +113,7 @@ in
             name = "kernel.org";
             url = "https://www.kernel.org";
           }
+          "separator"
           {
             name = "Nix sites";
             toolbar = true;