nix/2.home-manager
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

launchd+targets/darwin: Escape XML in plists (#7356)

Browse source 
This patch updates all usage of toPlist such that it escapes any strings
in the final output.

The motication for this change is to avoid confusion when end-users of
home-manager's APIs are not aware that the option values they set end up
being passed un-escaped to XML files.

BREAKING CHANGE: Consumers doing manual escaping will now be doubly escaped.

Co-authored-by: Linnnus <linnnus@users.noreply.github.com>
This commit is contained in:
lignus 2025-08-09 18:22:08 +02:00 • committed by GitHub
parent cc2fa2331a
commit 3ec1cd9a07
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
8 changed files with 35 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

13
modules/misc/news/2025/07/2025-07-01_22-15-34.nix Normal file
View file

@ -0,0 +1,13 @@
{ pkgs, ... }:
{
time = "2025-07-01T20:15:34+00:00";
condition = pkgs.stdenv.hostPlatform.isDarwin;
message = ''
XML characters are escaped for 'targets.darwin.keybindings' and 'launchd.agents.<name>'.
Special characters used in strings passed to 'targets.darwin.keybindings'
and 'launchd.agents.<name>' are now escaped before being included in the
generated plist files. If you were doing manual escaping you will need to
stop to avoid double escaping.
'';
}