From 7b34e428f31ce52baabda53e52bf14002e1c0625 Mon Sep 17 00:00:00 2001
From: Nick DeGroot <nick@nickthegroot.com>
Date: Wed, 10 Dec 2025 12:55:09 -0800
Subject: [PATCH] chromium: fix `null` package

---
 modules/programs/chromium.nix | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/modules/programs/chromium.nix b/modules/programs/chromium.nix
index 88b15f68..5344b60a 100644
--- a/modules/programs/chromium.nix
+++ b/modules/programs/chromium.nix
@@ -40,7 +40,7 @@ let
 
       finalPackage = mkOption {
         inherit visible;
-        type = types.package;
+        type = types.nullOr types.package;
         readOnly = true;
         description = ''
           Resulting customized ${name} package
@@ -220,15 +220,22 @@ let
       };
 
     in
+
     lib.mkIf cfg.enable {
-      programs.${browser}.finalPackage = lib.mkIf (cfg.package != null) (
+      assertions = [
+        {
+          assertion = !(cfg.package == null && cfg.commandLineArgs != [ ]);
+          message = "Cannot set `commandLineArgs` when `package` is null for ${browser}.";
+        }
+      ];
+
+      programs.${browser}.finalPackage =
         if cfg.commandLineArgs != [ ] then
           cfg.package.override {
             commandLineArgs = lib.concatStringsSep " " cfg.commandLineArgs;
           }
         else
-          cfg.package
-      );
+          cfg.package;
 
       home.packages = lib.mkIf (cfg.finalPackage != null) [
         cfg.finalPackage