nix/2.home-manager
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

neovim: fix extraLuaPackages type. (#3533)

Browse source 
Assigning to `programs.neovim.extraLuaPackages` a function taking a lua package set as input
and returning a list of packages, as described in the documentation,
threw an error because the rest of the code assumed that the value was always a plain list.
Using `lib.types.coercedTo`, we can accept such functions, as per the documentation,
as well as plain lists, which we then convert to a function ignoring its input argument.
We print a warning when a plain list is assigned, since the function
form is preferred, as it ensures that the right lua package set is used.

For the lua packages, we also get the lua package set from the
finalPackage, to make sure that we are always using the same package set
as the actual unwrapped neovim package being built.

For `programs.neovim.extraPythonPackages` I did the same.

I updated the test case so that we test both ways of setting these options.
This commit is contained in:
Ramses 2022-12-29 01:48:45 +01:00 • committed by GitHub
parent fa1bc088ea
commit a993eac106
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 81 additions and 61 deletions
Download patch file Download diff file Expand all files Collapse all files

44
tests/modules/programs/neovim/runtime.nix
View file

@ -4,28 +4,36 @@ with lib;
{
config = {
programs.neovim = {
enable = true;
plugins = with pkgs.vimPlugins; [
vim-nix
{
plugin = vim-commentary;
runtime = {
"after/ftplugin/c.vim".text = ''
" plugin-specific config
setlocal commentstring=//\ %s
setlocal comments=://
'';
};
}
];
programs.neovim = lib.mkMerge [
{
enable = true;
plugins = with pkgs.vimPlugins; [
vim-nix
{
plugin = vim-commentary;
runtime = {
"after/ftplugin/c.vim".text = ''
" plugin-specific config
setlocal commentstring=//\ %s
setlocal comments=://
'';
};
}
];
}
{
extraPython3Packages = ps: with ps; [ jedi pynvim ];
extraLuaPackages = ps: with ps; [ luacheck ];
}
{
extraPython3Packages = with pkgs.python3Packages; [ jedi pynvim ];
extraLuaPackages = with pkgs.lua51Packages; [ luacheck ];
}
];
extraPython3Packages = (ps: with ps; [ jedi pynvim ]);
};
nmt.script = ''
ftplugin="home-files/.config/nvim/after/ftplugin/c.vim"
assertFileExists "$ftplugin"
'';
};
}