From ae8003d8b61d0d373e7ca3da1a48f9c870d15df9 Mon Sep 17 00:00:00 2001
From: Austin Horstman <khaneliman12@gmail.com>
Date: Thu, 12 Feb 2026 21:36:59 -0600
Subject: [PATCH] mkFirefoxModule: remove visible option

Just default everything to show options to remove confusion / chance of
disabling documentation. We already set visible = true so it wasn't even
being used really.

Signed-off-by: Austin Horstman <khaneliman12@gmail.com>
---
 modules/programs/firefox/default.nix         | 1 -
 modules/programs/firefox/mkFirefoxModule.nix | 8 --------
 modules/programs/floorp.nix                  | 1 -
 modules/programs/librewolf.nix               | 1 -
 4 files changed, 11 deletions(-)

diff --git a/modules/programs/firefox/default.nix b/modules/programs/firefox/default.nix
index f9bbdfac..a9600c71 100644
--- a/modules/programs/firefox/default.nix
+++ b/modules/programs/firefox/default.nix
@@ -26,7 +26,6 @@ in
       name = "Firefox";
       wrappedPackageName = "firefox";
       unwrappedPackageName = "firefox-unwrapped";
-      visible = true;
 
       platforms.linux = {
         configPath = ".mozilla/firefox";
diff --git a/modules/programs/firefox/mkFirefoxModule.nix b/modules/programs/firefox/mkFirefoxModule.nix
index 5cf049c2..13e61c89 100644
--- a/modules/programs/firefox/mkFirefoxModule.nix
+++ b/modules/programs/firefox/mkFirefoxModule.nix
@@ -5,7 +5,6 @@
   wrappedPackageName ? null,
   unwrappedPackageName ? null,
   platforms,
-  visible ? false,
   enableBookmarks ? true,
 }:
 {
@@ -209,12 +208,10 @@ in
       example = true;
       description = ''
         Whether to enable ${appName}.${optionalString (description != null) " ${description}"}
-        ${optionalString (!visible) "See `${moduleName}` for more configuration options."}
       '';
     };
 
     package = mkOption {
-      inherit visible;
       type = with types; nullOr package;
       default = pkgs.${defaultPackageName};
       defaultText = literalExpression "pkgs.${packageName}";
@@ -317,7 +314,6 @@ in
     };
 
     nativeMessagingHosts = mkOption {
-      inherit visible;
       type = types.listOf types.package;
       default = [ ];
       description = ''
@@ -327,14 +323,12 @@ in
     };
 
     finalPackage = mkOption {
-      inherit visible;
       type = with types; nullOr package;
       readOnly = true;
       description = "Resulting ${appName} package.";
     };
 
     policies = lib.optionalAttrs (wrappedPackageName != null) (mkOption {
-      inherit visible;
       type = types.attrsOf jsonFormat.type;
       default = { };
       description = "[See list of policies](https://mozilla.github.io/policy-templates/).";
@@ -360,7 +354,6 @@ in
     };
 
     profiles = mkOption {
-      inherit visible;
       type = types.attrsOf (
         types.submodule (
           { config, name, ... }:
@@ -913,7 +906,6 @@ in
     };
 
     enableGnomeExtensions = mkOption {
-      inherit visible;
       type = types.bool;
       default = false;
       description = ''
diff --git a/modules/programs/floorp.nix b/modules/programs/floorp.nix
index 29db1633..2da23672 100644
--- a/modules/programs/floorp.nix
+++ b/modules/programs/floorp.nix
@@ -18,7 +18,6 @@ in
       name = "Floorp";
       wrappedPackageName = "floorp-bin";
       unwrappedPackageName = "floorp-bin-unwrapped";
-      visible = true;
 
       platforms.linux = {
         configPath = ".floorp";
diff --git a/modules/programs/librewolf.nix b/modules/programs/librewolf.nix
index b90e666b..c69d2322 100644
--- a/modules/programs/librewolf.nix
+++ b/modules/programs/librewolf.nix
@@ -34,7 +34,6 @@ in
       description = "LibreWolf is a privacy enhanced Firefox fork.";
       wrappedPackageName = "librewolf";
       unwrappedPackageName = "librewolf-unwrapped";
-      visible = true;
 
       platforms.linux = {
         configPath = ".librewolf";