From b5e86c1b19f178a8ee10f7cb747325e02e3d3991 Mon Sep 17 00:00:00 2001 From: Alex Martens Date: Sat, 2 May 2026 08:21:52 -0700 Subject: [PATCH] treewide: remove network-online.target systemd system units cannot be a dependency of a user-unit. Reference: https://github.com/systemd/systemd/issues/3312 --- modules/services/colima.nix | 2 -- modules/services/pantalaimon.nix | 1 - modules/services/pimsync.nix | 1 - modules/services/podman/linux/services.nix | 2 -- modules/services/rescrobbled.nix | 2 -- modules/services/restic.nix | 2 -- modules/services/tldr-update.nix | 2 -- modules/services/vdirsyncer.nix | 1 - .../services/colima/linux/colima-docker-cli-expected.service | 2 -- tests/modules/services/colima/linux/expected-service.service | 2 -- tests/modules/services/rescrobbled/basic-config.nix | 2 -- tests/modules/services/tldr-update/tldr-update.service | 2 -- 12 files changed, 21 deletions(-) diff --git a/modules/services/colima.nix b/modules/services/colima.nix index 63665d9ed..bd43e51ab 100644 --- a/modules/services/colima.nix +++ b/modules/services/colima.nix @@ -312,8 +312,6 @@ in lib.nameValuePair "colima-${name}" { Unit = { Description = "Colima container runtime (${name} profile)"; - After = [ "network-online.target" ]; - Wants = [ "network-online.target" ]; }; Service = { ExecStart = '' diff --git a/modules/services/pantalaimon.nix b/modules/services/pantalaimon.nix index 7b7da082b..badebf5e7 100644 --- a/modules/services/pantalaimon.nix +++ b/modules/services/pantalaimon.nix @@ -58,7 +58,6 @@ in pantalaimon = { Unit = { Description = "Pantalaimon - E2EE aware proxy daemon for matrix clients"; - After = [ "network-online.target" ]; }; Service = { diff --git a/modules/services/pimsync.nix b/modules/services/pimsync.nix index b2cda6445..ca222ab45 100644 --- a/modules/services/pimsync.nix +++ b/modules/services/pimsync.nix @@ -41,7 +41,6 @@ in systemd.user.services.pimsync = { Unit = { Description = "pimsync calendar and contacts synchronization"; - PartOf = [ "network-online.target" ]; }; Install.WantedBy = [ "default.target" ]; Service = { diff --git a/modules/services/podman/linux/services.nix b/modules/services/podman/linux/services.nix index 3fa84d802..84b44cf3f 100644 --- a/modules/services/podman/linux/services.nix +++ b/modules/services/podman/linux/services.nix @@ -42,8 +42,6 @@ in Unit = { Description = "Podman auto-update service"; Documentation = "man:podman-auto-update(1)"; - Wants = [ "network-online.target" ]; - After = [ "network-online.target" ]; }; Service = { diff --git a/modules/services/rescrobbled.nix b/modules/services/rescrobbled.nix index 0012c117e..85f6e6417 100644 --- a/modules/services/rescrobbled.nix +++ b/modules/services/rescrobbled.nix @@ -56,8 +56,6 @@ in Unit = { Description = "An MPRIS scrobbler"; Documentation = "https://github.com/InputUsername/rescrobbled"; - Wants = [ "network-online.target" ]; - After = [ "network-online.target" ]; }; Service.ExecStart = lib.getExe cfg.package; diff --git a/modules/services/restic.nix b/modules/services/restic.nix index 83211b208..f6c630f70 100644 --- a/modules/services/restic.nix +++ b/modules/services/restic.nix @@ -487,8 +487,6 @@ in lib.nameValuePair serviceName { Unit = { Description = "Restic backup service"; - Wants = [ "network-online.target" ]; - After = [ "network-online.target" ]; }; Service = { diff --git a/modules/services/tldr-update.nix b/modules/services/tldr-update.nix index 2e9eae3c0..5322ac68e 100644 --- a/modules/services/tldr-update.nix +++ b/modules/services/tldr-update.nix @@ -35,8 +35,6 @@ in Unit = { Description = "Update tldr CLI cache"; Documentation = "https://tldr.sh/"; - Wants = [ "network-online.target" ]; - After = [ "network-online.target" ]; }; Service = { diff --git a/modules/services/vdirsyncer.nix b/modules/services/vdirsyncer.nix index f58caa5ec..d145d2832 100644 --- a/modules/services/vdirsyncer.nix +++ b/modules/services/vdirsyncer.nix @@ -64,7 +64,6 @@ in systemd.user.services.vdirsyncer = { Unit = { Description = "vdirsyncer calendar&contacts synchronization"; - PartOf = [ "network-online.target" ]; }; Service = { diff --git a/tests/modules/services/colima/linux/colima-docker-cli-expected.service b/tests/modules/services/colima/linux/colima-docker-cli-expected.service index 9289ebdc4..c9fe5a154 100644 --- a/tests/modules/services/colima/linux/colima-docker-cli-expected.service +++ b/tests/modules/services/colima/linux/colima-docker-cli-expected.service @@ -17,6 +17,4 @@ StandardError=append:/home/hm-user/.local/state/colima/default.log StandardOutput=append:/home/hm-user/.local/state/colima/default.log [Unit] -After=network-online.target Description=Colima container runtime (default profile) -Wants=network-online.target diff --git a/tests/modules/services/colima/linux/expected-service.service b/tests/modules/services/colima/linux/expected-service.service index 9ee79b685..91c34ee19 100644 --- a/tests/modules/services/colima/linux/expected-service.service +++ b/tests/modules/services/colima/linux/expected-service.service @@ -15,6 +15,4 @@ StandardError=append:/home/hm-user/.local/state/colima/default.log StandardOutput=append:/home/hm-user/.local/state/colima/default.log [Unit] -After=network-online.target Description=Colima container runtime (default profile) -Wants=network-online.target diff --git a/tests/modules/services/rescrobbled/basic-config.nix b/tests/modules/services/rescrobbled/basic-config.nix index 285fef61c..70b7a1b76 100644 --- a/tests/modules/services/rescrobbled/basic-config.nix +++ b/tests/modules/services/rescrobbled/basic-config.nix @@ -39,8 +39,6 @@ assertFileExists $service assertFileRegex $service 'Description=An MPRIS scrobbler' - assertFileRegex $service 'Wants=network-online.target' - assertFileRegex $service 'After=network-online.target' assertFileRegex $service 'WantedBy=default.target' ''; } diff --git a/tests/modules/services/tldr-update/tldr-update.service b/tests/modules/services/tldr-update/tldr-update.service index 10d8c7f06..69adaebac 100644 --- a/tests/modules/services/tldr-update/tldr-update.service +++ b/tests/modules/services/tldr-update/tldr-update.service @@ -4,7 +4,5 @@ ExecStart=@tldr@/bin/dummy --update Type=oneshot [Unit] -After=network-online.target Description=Update tldr CLI cache Documentation=https://tldr.sh/ -Wants=network-online.target