nix/2.home-manager
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

rizin: cleanup according to feedback

Browse source 
In both prior feature pull requests for this module there was a review
after the pull request got merged, those are addressed here.
This commit is contained in:
rsahwe 2026-03-18 00:34:04 +01:00 • committed by Austin Horstman
parent a455ac1bb3
commit ba197beccc
5 changed files with 7 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

9
modules/programs/rizin.nix
View file

@ -6,7 +6,6 @@
}:
let
cfg = config.programs.rizin;
eValueType = with lib.types; either str (either int (either bool float));
in
{
meta.maintainers = [
@ -20,7 +19,7 @@ in
package = lib.mkPackageOption pkgs "rizin" { nullable = true; };
settings = lib.mkOption {
type = lib.types.attrsOf eValueType;
type = with lib.types; attrsOf (either str (either int (either bool float)));
default = { };
example = {
"asm.bytes" = true;
@ -53,11 +52,7 @@ in
config =
let
configFile =
if config.xdg.enable && config.home.preferXdgDirectories then
"${config.xdg.configHome}/rizin/rizinrc"
else
".rizinrc";
configFile = if config.xdg.enable then "${config.xdg.configHome}/rizin/rizinrc" else ".rizinrc";
configContent = ''
# settings
${lib.concatStringsSep "\n" (lib.mapAttrsToList (k: v: "e ${k}=${lib.toString v}") cfg.settings)}

2
tests/modules/programs/rizin/basic-configuration.nix
View file

@ -8,6 +8,6 @@
};
nmt.script = ''
assertFileExists "home-files/.rizinrc"
assertFileExists "home-files/.config/rizin/rizinrc"
'';
}

2
tests/modules/programs/rizin/default.nix
View file

@ -1,6 +1,6 @@
{
rizin-basic-configuration = ./basic-configuration.nix;
rizin-disabled-configuration = ./disabled-configuration.nix;
rizin-prefer-xdg = ./prefer-xdg.nix;
rizin-xdg-disabled = ./xdg-disabled.nix;
rizin-settings-configuration = ./settings-configuration.nix;
}

2
tests/modules/programs/rizin/settings-configuration.nix
View file

@ -8,6 +8,6 @@
};
nmt.script = ''
assertFileExists "home-files/.rizinrc"
assertFileExists "home-files/.config/rizin/rizinrc"
'';
}

6
tests/modules/programs/rizin/prefer-xdg.nix → tests/modules/programs/rizin/xdg-disabled.nix
View file

@ -1,7 +1,5 @@
{
xdg.enable = true;
home.preferXdgDirectories = true;
xdg.enable = false;
programs.rizin = {
enable = true;
@ -12,6 +10,6 @@
};
nmt.script = ''
assertFileExists "home-files/.config/rizin/rizinrc"
assertFileExists "home-files/.rizinrc"
'';
}