Merge pull request #349 from hercules-ci/issue-348

fix(inputs'): do not unnecessarily evaluate formatters

dev/tests/nix-unit.nix

@@ -567,6 +567,31 @@ in
     };
   };
 
+  perInput = {
+    "test: inputs' does not evaluate input flake formatter" =
+      let
+        inputFlake = {
+          _type = "flake";
+          outPath = "/fake";
+          formatter = throw "must not evaluate input's formatter";
+          packages.a.hello = pkg "a" "hello";
+        };
+        self = { _type = "flake"; outPath = "/test"; inputs = { inherit self; dep = inputFlake; }; };
+        result = mkFlake
+          { inputs = self.inputs; }
+          {
+            systems = [ "a" ];
+            perSystem = { inputs', ... }: {
+              packages.default = inputs'.dep.packages.hello;
+            };
+          };
+      in
+      {
+        expr = (result.packages.a.default).name;
+        expected = "hello";
+      };
+  };
+
   formatter = {
     "test: conditional null throws helpful error" = {
       expr =

modules/formatter.nix

@@ -100,10 +100,9 @@ in
               '')
           config.allSystems);
 
-    perInput = system: flake:
-      optionalAttrs (flake?formatter.${system}) {
-        formatter = flake.formatter.${system};
-      };
+    perInput = system: flake: {
+      formatter = flake.formatter.${system};
+    };
 
   };
 }