From f910ac37b62f28ef613b2947c27f34359ceb9f41 Mon Sep 17 00:00:00 2001 From: Sander Date: Thu, 28 Aug 2025 12:51:30 +0200 Subject: [PATCH] github-runner: fix the nodeRuntimes option The conditional override was intended to be backwards-compatible with older runner packages without the `nodeRuntimes` argument. However, `override` doesn't yield default arguments, so the override was never applied. This commit removes the conditional entirely since `nodeRuntimes` was added back in 24.05. --- modules/services/github-runner/service.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/services/github-runner/service.nix b/modules/services/github-runner/service.nix index e212b88..51658d6 100644 --- a/modules/services/github-runner/service.nix +++ b/modules/services/github-runner/service.nix @@ -76,7 +76,7 @@ in config.launchd.daemons = flip mapAttrs' config.services.github-runners (name: cfg: let - package = cfg.package.override (old: optionalAttrs (hasAttr "nodeRuntimes" old) { inherit (cfg) nodeRuntimes; }); + package = cfg.package.override { inherit (cfg) nodeRuntimes; }; stateDir = mkStateDir cfg; logDir = mkLogDir cfg; workDir = mkWorkDir cfg;