pkg/mmv
1
0
Fork 0
mirror of https://github.com/itchyny/mmv.git synced 2025-12-30 09:11:34 +08:00
Code Issues Projects Releases Packages Wiki Activity Actions

split EDITOR in Go to remove dependency on sh (ref #19)

Browse source
This commit is contained in:
itchyny 2023-04-21 22:12:21 +09:00
parent f627dff093
commit 7c8adbbb4c
3 changed files with 15 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

13
cmd/mmv/main.go
View file

@ -9,6 +9,7 @@ import (
"runtime"
"strings"
"github.com/kballard/go-shellquote"
_ "github.com/mattn/getwild"
"github.com/mattn/go-tty"
@ -98,7 +99,17 @@ func rename(args []string) error {
}
defer tty.Close()
cmd := exec.Command("sh", "-c", `eval exec "${EDITOR:-vi}" '"$@"'`, "", f.Name())
editor := os.Getenv("EDITOR")
if editor == "" {
editor = "vi"
}
editorWithArgs, err := shellquote.Split(editor)
if err != nil {
return fmt.Errorf("%s: %s", err, editor)
}
editorWithArgs = append(editorWithArgs, f.Name())
cmd := exec.Command(editorWithArgs[0], editorWithArgs[1:]...)
cmd.Stdin = tty.Input()
cmd.Stdout = tty.Output()
cmd.Stderr = tty.Output()